Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new access modifier package swift 5.9 #180

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Support new access modifier package swift 5.9 #180

merged 1 commit into from
Feb 1, 2024

Conversation

nhenri
Copy link
Contributor

@nhenri nhenri commented Jan 30, 2024

  • Modify DependencyEndpoint macro to support new access modifier package

@stephencelis
Copy link
Member

@nhenri Thanks for the PR! Want to add another macro test to capture this change?

@nhenri
Support new access modifier package
c1632b4 
- Modify DependencyEndpoint macro to support new access modifier package
- Add unit test to capture this change
@nhenri nhenri force-pushed the package-access-modifier-support branch from fc944ba to c1632b4 Compare February 1, 2024 00:09
@nhenri
Copy link
Contributor Author

nhenri commented Feb 1, 2024

@stephencelis Done, my commit is amend with macro test.

stephencelis
stephencelis approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 6c7991f into pointfreeco:main Feb 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhenri @stephencelis