Clearer warning message when you provide an unimplemented default val…

…ue inside an @DependencyClient. (#167)
pointfreeco · Jan 5, 2024 · a22fd06 · a22fd06
1 parent 38a9223
commit a22fd06
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Sources/DependenciesMacrosPlugin/Support.swift b/Sources/DependenciesMacrosPlugin/Support.swift
@@ -96,8 +96,9 @@ extension InitializerClauseSyntax {
             node: self.value,
             message: MacroExpansionWarningMessage(
               """
-              Do not use 'unimplemented' with '@\(attribute.attributeName)'; it is a replacement and \
-              implements the same runtime functionality as 'unimplemented' at compile time
+              Do not use 'unimplemented' with '@\(attribute.attributeName)'; the \
+              '@\(attribute.attributeName)' macro already includes the behavior of \
+              'unimplemented'.
               """
             )
           )

diff --git a/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift b/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift
@@ -875,7 +875,7 @@ final class DependencyClientMacroTests: BaseTestCase {
         var bar: () -> Int = unimplemented()
                              ┬──────────────
                              ├─ 🛑 '@DependencyClient' default must be closure literal
-                             ╰─ ⚠️ Do not use 'unimplemented' with '@DependencyClient'; it is a replacement and implements the same runtime functionality as 'unimplemented' at compile time
+                             ╰─ ⚠️ Do not use 'unimplemented' with '@DependencyClient'; the '@DependencyClient' macro already includes the behavior of 'unimplemented'.
       }
       """
     }

diff --git a/Tests/DependenciesMacrosPluginTests/DependencyEndpointMacroTests.swift b/Tests/DependenciesMacrosPluginTests/DependencyEndpointMacroTests.swift
@@ -717,7 +717,7 @@ final class DependencyEndpointMacroTests: BaseTestCase {
         var bar: () -> Int = unimplemented()
                              ┬──────────────
                              ├─ 🛑 '@DependencyEndpoint' default must be closure literal
-                             ╰─ ⚠️ Do not use 'unimplemented' with '@DependencyEndpoint'; it is a replacement and implements the same runtime functionality as 'unimplemented' at compile time
+                             ╰─ ⚠️ Do not use 'unimplemented' with '@DependencyEndpoint'; the '@DependencyEndpoint' macro already includes the behavior of 'unimplemented'.
       }
       """
     }