Add missing NSPrivacyCollectedDataTypes to PrivacyInfo.xcprivacy #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DandyLyons Can the array be empty? |
|
It's not an array. It's a string. Also the NSPrivacyCollectedDataType is not allowed to be an empty string. And it must be one of the approved strings. |
Co-authored-by: Stephen Celis <[email protected]>
|
Looks good with the empty array now. It generates an empty Privacy Report again. |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Apr 30, 2024
…ure to from: "1.10.1" (#1054) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://github.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.10.0"` -> `from: "1.10.1"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.10.1`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.10.1) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.10.0...1.10.1) #### What's Changed - Fixed: Support nested enum reducers (thanks [@​sk409](https://github.com/sk409), [https://github.com/pointfreeco/swift-composable-architecture/pull/2814](https://github.com/pointfreeco/swift-composable-architecture/pull/2814)). - Fixed: Add missing `NSPrivacyCollectedDataTypes` to PrivacyInfo.xcprivacy (thanks [@​DandyLyons](https://github.com/DandyLyons), [https://github.com/pointfreeco/swift-composable-architecture/pull/3027](https://github.com/pointfreeco/swift-composable-architecture/pull/3027)). - Fixed: Emit test failure when warning in release ([https://github.com/pointfreeco/swift-composable-architecture/pull/3024](https://github.com/pointfreeco/swift-composable-architecture/pull/3024)). - Fixed: Bump Perception availability to support 1.1.6 ([https://github.com/pointfreeco/swift-composable-architecture/pull/3025](https://github.com/pointfreeco/swift-composable-architecture/pull/3025)). - Infrastructure: Update README for TCA 1.10.0 (thanks [@​kalupas226](https://github.com/kalupas226), [https://github.com/pointfreeco/swift-composable-architecture/pull/3019](https://github.com/pointfreeco/swift-composable-architecture/pull/3019)). - Infrastructure: Fix DocC organization of shared state tools ([https://github.com/pointfreeco/swift-composable-architecture/pull/3022](https://github.com/pointfreeco/swift-composable-architecture/pull/3022)). - Infrastructure: Remove `Reducer._Body` workaround ([https://github.com/pointfreeco/swift-composable-architecture/pull/3023](https://github.com/pointfreeco/swift-composable-architecture/pull/3023)). #### New Contributors - [@​sk409](https://github.com/sk409) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2814](https://github.com/pointfreeco/swift-composable-architecture/pull/2814) **Full Changelog**: pointfreeco/swift-composable-architecture@1.10.0...1.10.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision of: #2930
Per: #3021
The Xcode behavior appears to be different from when I submitted PR 2930. I originally created the manifest without NSPrivacyCollectedDataTypes (since TCA is not actually collecting anything) and Xcode generated an empty Privacy Report.
Now it generates the error
Missing an expected key: 'NSPrivacyCollectedDataTypes'I've now added the key in however, it no longer generates an empty Privacy Report, so I think it needs to be a library decision how we proceed. Here's the new generated report.
According to this we are collecting "other" data even though TCA isn't collecting anything and even though we already have an Apple-approved exemption (C56D.1). I believe that this is misleading to library users, and Apple may force app makers to include this in their final App Store nutrition label declaration, which would be further misleading to customers.