-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift bug workaround for TestStore
completion
#2923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Mar 18, 2024
/// - prepareDependencies: A closure that can be used to override dependencies that will be | ||
/// accessed during the test. These dependencies will be used when producing the initial | ||
/// state. | ||
public init<R: Reducer>( | ||
initialState: @autoclosure () -> R.State, | ||
@ReducerBuilder<State, Action> reducer: () -> R, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We unfortunately can't add a deprecated, disfavored overload of this initializer.
Invalid redeclaration of 'init(initialState:reducer:withDependencies:file:line:)'
mbrandonw
approved these changes
Mar 18, 2024
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 22, 2024
…ure to from: "1.9.3" (#1020) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://github.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.9.2"` -> `from: "1.9.3"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.9.3`](https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.9.3) [Compare Source](https://github.com/pointfreeco/swift-composable-architecture/compare/1.9.2...1.9.3) #### What's Changed - Added: Added missing `StackActionOf<R>` type alias (thanks [@​d-date](https://github.com/d-date), [pointfreeco/swift-composable-architecture#2906). - Fixed: Cache scoped presentation stores where possible (thanks [@​lukeredpath](https://github.com/lukeredpath), [pointfreeco/swift-composable-architecture#2908). - Fixed: Allow "inert" enum state to be observed by having an ever-changing ID ([pointfreeco/swift-composable-architecture#2910). - Fixed: Silence SwiftSyntax 510 / Xcode 15.3 warnings ([pointfreeco/swift-composable-architecture#2909). - Fixed: Restore `TestStore` autocompletion ([pointfreeco/swift-composable-architecture#2923). - Fixed: It is now possible to scope bindings of enum stores to non-reducer cases for sheets and other navigation ([pointfreeco/swift-composable-architecture#2943). - Fixed: `package` access modifier support in enum `@Reducer` macro (thanks [@​samrayner](https://github.com/samrayner), [pointfreeco/swift-composable-architecture#2939). - Fixed: `Effect.publisher` is no longer escaping ([pointfreeco/swift-composable-architecture#2968). - Fixed: Add runtime warning diagnostic to catch nested calls to `observe` ([pointfreeco/swift-composable-architecture#2996). - Infrastructure: Fix documentation typos (thanks [@​takehilo](https://github.com/takehilo), [pointfreeco/swift-composable-architecture#2898; [pointfreeco/swift-composable-architecture#2944); tutorial fixes (thanks [@​LRSnowX](https://github.com/LRSnowX), [pointfreeco/swift-composable-architecture#2808); test store tutorial/documentation fixes ([pointfreeco/swift-composable-architecture#2912); fix favorites case study mocks (thanks [@​beribas](https://github.com/beribas), [pointfreeco/swift-composable-architecture#2962); improve docs for stack-based navigation ([pointfreeco/swift-composable-architecture#2967); fix dismissal in UIKit demos ([pointfreeco/swift-composable-architecture#2986) fix shared state case study (thanks [@​eltociear](https://github.com/eltociear), [pointfreeco/swift-composable-architecture#2994). #### New Contributors - [@​LRSnowX](https://github.com/LRSnowX) made their first contribution in [pointfreeco/swift-composable-architecture#2808 - [@​beribas](https://github.com/beribas) made their first contribution in [pointfreeco/swift-composable-architecture#2962 - [@​samrayner](https://github.com/samrayner) made their first contribution in [pointfreeco/swift-composable-architecture#2939 - [@​eltociear](https://github.com/eltociear) made their first contribution in [pointfreeco/swift-composable-architecture#2994 **Full Changelog**: pointfreeco/swift-composable-architecture@1.9.2...1.9.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Swift bug, stores and test stores initialized with type inference are broken when it comes to autocomplete:
swiftlang/swift#72399
For example, this test store cannot be completed from:
While this can affect regular stores, as well, it is less likely outside of root stores, since stores are typically declared in views and view controllers as properties, and inference isn't required:
While the user can employ a workaround in their project by making the types very explicit:
This PR takes the approach of removing the builder context from
TestStore.init
, since the issue is more common in tests, and because composing a reducer for a test store is less common.