Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.exit to avoid strange behavour. #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nigelsim
Copy link

When a service ends using System.exit(), such as in the MainService class, the services control reports Error 1053: The service did not respond to the start or control request in a timely fashion. If I replace this with just returning from main then everything works file.

This is an issue for me because I'd like to just use my normal main entry point, as I utilise Runtime shutdown handlers to cleanup (which also run correctly, despite the service handler freaking out).

Perhaps the answer is actually to change the way MainService runs so that it doesn't call System.exit(). This pull request runs the service in a thread, and uses the main thread to monitor.

@poidasmith
Copy link
Owner

Unfortunately some other users rely on this behaviour as they are using third party libraries that don't shut down non-daemon threads. I can certainly make it configurable via an INI option.

@nigelsim
Copy link
Author

Fair enough. It may just be easier to provide it as a separate class given the difference is non-trivial. Just a thought.

Thanks for the project too, much appreciated.

@melloware
Copy link

Thank you for posting this. I had to use this code with 1 minor tweak to get my "Error 109: Pipe Ended" error from Windows. I added a System.exit(0) right before the return 0 to make my Spring application stop gracefully. Woks like a charm now and my service stops and starts gracefully.

      System.exit(0);
      return 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants