Remove System.exit to avoid strange behavour. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a service ends using System.exit(), such as in the MainService class, the services control reports Error 1053: The service did not respond to the start or control request in a timely fashion. If I replace this with just returning from main then everything works file.
This is an issue for me because I'd like to just use my normal main entry point, as I utilise Runtime shutdown handlers to cleanup (which also run correctly, despite the service handler freaking out).
Perhaps the answer is actually to change the way MainService runs so that it doesn't call System.exit(). This pull request runs the service in a thread, and uses the main thread to monitor.