Conversation
| @@ -0,0 +1,4 @@ | |||
| type Func = (v?: any) => any | Promise<any> | |||
There was a problem hiding this comment.
Sadly TypeScript doesn't have any decent support for the the most important FP functions like curry, compose, pipe... and even some cases of reduce. See this comment by one of the authors of Ramda's type declarations, and the Variadict Kinds Proposal.
You can hack around TS' limitation by providing one function overload per function arity.
It isn't pretty or very maintainable, but I think it still would add a lot of value since we rarely compose/pipe too many functions and it'd give us type safety in our pipes.
Wanna give it a shot?
Feel free to merge as-is though, code looks good and the tests are awesome.
There was a problem hiding this comment.
Yeah, for some reason I though they had solved it partial in TS 3.0, but when I started looking around it seems they have not.
I think I will merge this as is, then I will go back and add the better typings.
lautarodragan
left a comment
lautarodragan
left a comment
There was a problem hiding this comment.
- [no] Tested changes manually
- Checked accidental architectural/style changes
- Reviewed entire diff
- Unit tests
- [n/a] Documentation
- Filenames and locations
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
PR Process - PR Review Checklist
Release
Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.
Description of Changes
I couldn't find a way to use better types than any. Let me know if you have ideas.
I am using .catch instead of RITEways Try because RITEways Try does not await promises and can still crash the test runner.