Skip to content

Avoid some property() calls #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poelzi merged 1 commit into from
Oct 11, 2017
Merged

Avoid some property() calls #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/widget/wtracktableview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1498,13 +1498,13 @@ void WTrackTableView::addSelectionToPlaylist(int iPlaylistId) {
playlistDao.appendTracksToPlaylist(trackIds, iPlaylistId);
}

void WTrackTableView::addRemoveSelectionInCrate(QWidget* qc) {
QVariant crateqv = qc->property("crateId");
if (!crateqv.canConvert<CrateId>()) {
qWarning() << "crateId is not ef CrateId type";
void WTrackTableView::addRemoveSelectionInCrate(QWidget* pWidget) {
auto pCheckBox = qobject_cast<QCheckBox*>(pWidget);
VERIFY_OR_DEBUG_ASSERT(pCheckBox) {
qWarning() << "pWidget is not a QCheckBox";
return;
}
CrateId crateId = crateqv.value<CrateId>();
CrateId crateId = pCheckBox->property("crateId").value<CrateId>();

const QList<TrackId> trackIds = getSelectedTrackIds();

Expand All @@ -1514,10 +1514,8 @@ void WTrackTableView::addRemoveSelectionInCrate(QWidget* qc) {
}

// we need to disable tristate again as the mixed state will now be gone and can't be brought back
if (qc->property("tristate").toBool() == true) {
qc->setProperty("tristate", false);
}
if(qc->property("checked").toBool() == false) {
pCheckBox->setTristate(false);
if(!pCheckBox->isChecked()) {
if (crateId.isValid()) {
m_pTrackCollection->removeCrateTracks(crateId, trackIds);
}
Expand Down