Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapped most of the osgEarth related classes #16

Closed
wants to merge 1 commit into from

Conversation

devcxx
Copy link

@devcxx devcxx commented Jul 11, 2017

hope you can sort it out @podsvirov

@devcxx devcxx changed the title i wrapped most of the osgEarth related classes, hope you sort it out wrapped most of the osgEarth related classes Jul 11, 2017
@podsvirov
Copy link
Owner

A great job, thank you for your efforts!

It seems to me that you are a kind and cheerful person... The process of reviewing your changes will take some time :-) (I am engaged in this project in my spare time, and I do not have much of it).

@devcxx
Copy link
Author

devcxx commented Jul 11, 2017

thanks, you do a great job too :) , by the way hope you can solve #13 issues

@podsvirov
Copy link
Owner

@devcxx, you did a lot of work, but how did you test the performance of your code? The osgQtQuick project uses a CMake building system. In your changes there is only the *.pri files and not any CMakeLists.txt modifications.
Nevertheless, if you somehow built it, do you have any examples of scripts for manual checking, like a tests/earth.qml file?

@devcxx devcxx closed this Nov 27, 2017
@devcxx devcxx deleted the develop branch November 27, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants