feat(frontend/forms): auto select container engines#1089
Merged
axel7083 merged 3 commits intoDec 26, 2025
Merged
Conversation
axel7083
requested review from
benoitf,
bmahabirbu and
simonrey1
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
simonrey1
approved these changes
Dec 26, 2025
Contributor
simonrey1
left a comment
simonrey1
left a comment
There was a problem hiding this comment.
LGTM
For Quadlet Generate form it seems to work on my Mac: the podman engine is auto selected.
I tried to access Quadlet Compose form through command and interface but no luck.
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
force-pushed
the
feature/frontend/forms/auto-select-container-engine
branch
from
b863824 to
3be6564
Compare
Collaborator
Author
|
Funny enough, there were 10 lines of code to select the container engine, but now this is not needed! So removing those lines. |
Collaborator
Author
The compose form is kinda hidden because it lack so many features. You can check https://github.com/podman-desktop/extension-podman-quadlet?tab=readme-ov-file#compose to see how to access it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today, the
Generate Quadletform has aContainer Engineselect, but this one is undefined by default but is required. This is not ideal, as we should auto select the first one for the user to ease the form usage.💡 Since we auto select the first container engine, we need to remove the
clearableoption in the forms, so the first commit 989c460 is here to add this feature, and the second commit b863824 is here to use this new exposedclearableprops.packages/frontend/src/lib/select/Select.sveltecannot be migrated to Svelte5 :( (Upstream issue rob-balfre/svelte-select#716)Screenshots
Screencast.From.2025-12-23.14-49-21.mp4
Related issues
Fixes #1016
Testing