Skip to content

[release-1.11] Cirrus: Add CI self-destruct condition on EOL date#1991

Merged
mtrmac merged 1 commit into
podman-container-tools:release-1.11from
cevich:release_1.11_add_self_destruct
May 9, 2023
Merged

[release-1.11] Cirrus: Add CI self-destruct condition on EOL date#1991
mtrmac merged 1 commit into
podman-container-tools:release-1.11from
cevich:release_1.11_add_self_destruct

Conversation

@cevich

@cevich cevich commented May 3, 2023

Copy link
Copy Markdown
Contributor

This branch will never receive any security-backports when the associated RHEL release reaches EOL. Add a condition to force CI to break with a helpful message, after this RHEL EOL date.

This branch will never receive any security-backports when the
associated RHEL release reaches EOL.  Add a condition to force CI to
break with a helpful message, after this RHEL EOL date.

Signed-off-by: Chris Evich <cevich@redhat.com>

@mtrmac mtrmac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is assuming that the 9.3/8.9 RHELs will come from a future new branch, do I understand that correctly? Otherwise the last possible EOL seem to be further in the future.

(If that’s the intent, that’s fine; I agree it’s a good habit to have the _EOL code on all branches; we can always move the date out.)

@cevich

cevich commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

This is assuming that the 9.3/8.9 RHELs will come from a future new branch

OIC the problem. I was blindly going by a list Jindrich shared with me, cross-referencing a google sheet of RHEL releases and EOL dates, I didn't even look at the RHEL versions. Let me double-check and see if there's a release currently using 1.11 which is going EOL sooner. That's probably a safer date to use. Thanks for checking @mtrmac

@cevich
cevich marked this pull request as draft May 8, 2023 14:49
@cevich

cevich commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

Err wait...the changes for this branch are for 9.2/8.2. I just double-checked, and the EOL date is correct for this branch and those RHEL releases.

This is assuming that the 9.3/8.9 RHELs will come from a future new branch

Not necessarily, but those are odd-numbered releases, so they will EOL sooner. We want the EOL date set to the latest possible date (which it is). If a new branch is made for 9.3/8.9, it will need to have its own separate EOL-check added on branch creation.

@cevich
cevich marked this pull request as ready for review May 8, 2023 15:01
@mtrmac

mtrmac commented May 9, 2023

Copy link
Copy Markdown
Contributor

Actually, https://gitlab.com/redhat/centos-stream/rpms/skopeo/-/tree/c9s is now at 1.12, so a future branch will almost certainly be post-1.11, making the (already fairly hypothetical) concern of future 1.11-based branches moot.

@mtrmac
mtrmac merged commit 7e11ab4 into podman-container-tools:release-1.11 May 9, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants