Remove refs to crio/conmon

[cevich]

Signed-off-by: Chris Evich cevich@redhat.com

[haircommander]

while we're here can you add to the second line /usr/local/libexec/podman/conmon ?

[haircommander]

regardless of if you do LGTM thanks @cevich

[rhatdan]

Tests are not happy with this PR.
@mheon PTAL

[cevich]

@rhatdan @mheon it's only my first try, TBH I'm surprised it even compiled 😁

Goal here is to get podman in-line with a new reality of conmon being separated from cri-o when installed via package (the #1936 connection). So until that PR is ready, I think perhaps I need to set $CONMON_BINARY for all distros. so the tests can pass.

while we're here can you add to the second line /usr/local/libexec/podman/conmon ?

I can, and am happy to adjust anything else as well. I'm not very happy about the separate paths we search through in the int. tests, there's gotta be a better way to handle that.

[cevich]

@mheon @haircommander @rhatdan PTAL, tests passing now. I tried to change as little as possible here, so it's certainly not ideal. However, for the vast majority of cases it should allow CI and human testing to function with multiple versions of conmon available at once. I'm still open if any of the search path order needs to be tweaked, juss lemmie know.

[haircommander]

LGTM, I like how podman specific locations are searched first. I can't comment on which should be first /usr/local/.. vs /usr.. and so on though.

[cevich]

I can't comment on which should be first

In my experience, typically the list should go in order of most-special to least-special, with env. vars and config files being in the former category. So less obvious places like /usr/local/... should come first, and more "standard" places like /usr/bin should be last.

[rhatdan]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm