Skip to content

Remove bin/podman.cross Make target#26326

Merged
openshift-merge-bot[bot] merged 1 commit into
podman-container-tools:mainfrom
ninja-quokka:makefile2
Jun 9, 2025
Merged

Remove bin/podman.cross Make target#26326
openshift-merge-bot[bot] merged 1 commit into
podman-container-tools:mainfrom
ninja-quokka:makefile2

Conversation

@ninja-quokka

Copy link
Copy Markdown
Contributor

The local-cross Make target has superceeded this old Make target and the warning to not use it has been in place now for 4+ years.

Removing it to clean up the Makefile slightly.

Does this PR introduce a user-facing change?

None

The local-cross Make target has superceeded this old Make target and the
warning to not use it has been in place now for 4+ years.

Removing it to clean up the Makefile slightly.

Signed-off-by: Lewis Roy <lewis@redhat.com>
@baude

baude commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

/approve
LGTM

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@baude baude added the No New Tests Allow PR to proceed without adding regression tests label Jun 9, 2025
@packit-as-a-service

Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@openshift-ci

openshift-ci Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, giuseppe, lsm5, ninja-quokka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [baude,giuseppe,lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 8ab61ad into podman-container-tools:main Jun 9, 2025
84 of 85 checks passed
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 8, 2025
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants