Skip to content

Makefile: fix darwin detection - #13020

Merged
openshift-merge-robot merged 1 commit into
podman-container-tools:v3.4from
zeha:12975-fix-12327
Jan 26, 2022
Merged

Makefile: fix darwin detection#13020
openshift-merge-robot merged 1 commit into
podman-container-tools:v3.4from
zeha:12975-fix-12327

Conversation

@zeha

@zeha zeha commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

NATIVE_GOOS does not exist in the 3.4 branch, only on main.
Fixes my backport #12327. Verified to fix #12975 (again) for me.

Signed-off-by: Chris Hofstaedtler chris.hofstaedtler@deduktiva.com

NATIVE_GOOS does not exist in the 3.4 branch, only on main.
Fixes my backport podman-container-tools#12327. Verified to fix podman-container-tools#12975 (again) for me.

Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
@rhatdan

rhatdan commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

LGTM

@baude

baude commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, zeha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@baude

baude commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

/hold
/lgtm

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@rhatdan

rhatdan commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@openshift-merge-robot
openshift-merge-robot merged commit a54320a into podman-container-tools:v3.4 Jan 26, 2022
@zeha
zeha deleted the 12975-fix-12327 branch January 26, 2022 17:18
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants