Skip to content

Don't use docker/pkg/archive, use containers/storage/pkg/archive - #11971

Merged
openshift-merge-robot merged 1 commit into
podman-container-tools:mainfrom
rhatdan:archive
Oct 14, 2021
Merged

Don't use docker/pkg/archive, use containers/storage/pkg/archive#11971
openshift-merge-robot merged 1 commit into
podman-container-tools:mainfrom
rhatdan:archive

Conversation

@rhatdan

@rhatdan rhatdan commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-ci

openshift-ci Bot commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@rhatdan

rhatdan commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

@nalind Any idea why imagebuilder uses
docker "github.com/fsouza/go-dockerclient"

This end up pulling in all of the docker archive stuff into Podman.

@mheon

mheon commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

LGTM

@nalind

nalind commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

@nalind Any idea why imagebuilder uses docker "github.com/fsouza/go-dockerclient"

It connects to a docker daemon, and the package offers an API for doing that. Some of its types (Config and Image) are baked into imagebuilder's exported API, so it can't easily be replaced with something else.

@TomSweeneyRedHat

Copy link
Copy Markdown
Contributor

LGTM

@TomSweeneyRedHat

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@openshift-merge-robot
openshift-merge-robot merged commit 77ae43a into podman-container-tools:main Oct 14, 2021
@github-actions github-actions Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants