Add note about empty fields and null values for API responses - #11833
Merged
openshift-merge-robot merged 1 commit intoOct 1, 2021
Conversation
openshift-ci
Bot
added
the
approved
Contributor
Author
Contributor
|
LGTM |
Add a note the global swagger docs about some fields not showing up in responses as they are set to omitempty. Also add a note about null values for complicated field types that swagger-go has a hard time with. [NO TESTS NEEDED] Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
Contributor
|
/lgtm |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
one suspected flake test, I restarted. |
Contributor
|
LGTM |
Contributor
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
github-actions
Bot
added
the
locked - please file new issue/PR
edsantiago
added
the
No New Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NO TESTS NEEDED]
Signed-off-by: Urvashi Mohnani umohnani@redhat.com
What this PR does / why we need it:
Add a note the global swagger docs about some fields not showing
up in responses as they are set to omitempty. Also add a note about
null values for complicated field types that swagger-go has a hard time
with.
How to verify it
Check swagger docs for update
Which issue(s) this PR fixes:
Fixes #11826
Fixes #11830
Special notes for your reviewer: