Fix Error, empty output for info: 'VERSION' - #11631
Merged
openshift-merge-robot merged 1 commit intoSep 21, 2021
Merged
Conversation
Contributor
Author
|
hehehe, |
cevich
force-pushed
the
replace_hack-get_release_info
branch
from
September 17, 2021 15:42
7e60223 to
b44c181
Compare
Contributor
|
LGTM |
Contributor
Author
It's Friday...I've lost all hope 🤣 |
Contributor
|
/lgtm |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Luap99
reviewed
Sep 20, 2021
cevich
force-pushed
the
replace_hack-get_release_info
branch
from
September 20, 2021 18:50
b44c181 to
af34151
Compare
cevich
force-pushed
the
replace_hack-get_release_info
branch
3 times, most recently
from
September 20, 2021 19:14
789015d to
a11c5c1
Compare
When building releases, the definitive canonical version of podman (or podman-remote) is needed. Previously this was accomplished by scraping `version/version.go`. However, due to tooling differences across platforms, this has proven problematic, unreliable, and hard to maintain. Fix this by building and caching a small golang binary who's only purpose is to print the version number to stdout. This not only provides a quick and reliable way to determine the current version, it also acts as a check on the version API vs tooling that relies on it. Lastly, remove several `RELEASE_*` Makefile definitions which aren't actually used anywhere. These were originally added a very long time ago to serve as part of a long since retired release process. The remaining items, were updated to make use of the new `.podmanversion` binary on an as-required basis (i.e. not every time `make` is run). Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
replace_hack-get_release_info
branch
from
September 21, 2021 16:29
a11c5c1 to
34043bd
Compare
Contributor
Author
|
Update: Avoid make printing |
Contributor
Author
|
Okay, I think this one is ready. |
Contributor
|
/lgtm |
openshift-ci
Bot
added
lgtm
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building releases, the definitive canonical version of podman (or
podman-remote) is needed. Previously this was accomplished by scraping
version/version.go. However, due to tooling differences acrossplatforms, this has proven problematic, unreliable, and hard to
maintain.
Fix this by building and caching a small golang binary who's only purpose
is to print the version number to stdout. This not only provides a quick
and reliable way to determine the current version, it also acts as a check
on the version API vs tooling that relies on it.
Lastly, remove several
RELEASE_*Makefile definitions which aren'tactually used anywhere. These were originally added a very long time
ago to serve as part of a long since retired release process. The
remaining items, were updated to make use of the new
test/version/versionbinary on an as-required basis (i.e. not every time
makeis run).