DO-NOT-MERGE: Add squash-all for podman build - #1900
Closed
TomSweeneyRedHat wants to merge 1 commit into
Closed
Conversation
Add a `--squash-all` flag that will be unique to `podman build` and will not be used by Buildah. `buildah bud --layers=false` is equivalent to `docker build --squash`. When a podman build command includes the `--squash` option, podman will tranlate that to `--layers=false` for the build build api code. A `docker build` call is equivalent to `podman build` or `podman build --layers=true` and that's not changing. When podman build uses the `--squash-all` command, it will turn on the --squash option for the buildah bud api to have only one layer returned by the buildah bud code. There's not a Docker equivalent for this at the moment. I'll hopefully be spinning up a Podman PR in the next day or two that will use this new option. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Contributor
Author
|
FYI @mheon |
Contributor
Author
|
fyi @baude |
rhatdan
reviewed
Oct 8, 2019
| UTS string | ||
| } | ||
|
|
||
| // PodmanBuildResults represents the results for Podman Build flags |
Contributor
There was a problem hiding this comment.
Can't we just add this to Podman?
libpod/cmd/build.go?
Contributor
Author
There was a problem hiding this comment.
Probably. All the other definitions are here, so thought I'd keep them together. I'll try adding it to cmd/build.go.
Contributor
Author
There was a problem hiding this comment.
Per @rhatdan's suggestion, I've moved this code into Podman in podman-container-tools/podman#4215. If those changes are merged there, I will close this PR.
TomSweeneyRedHat
changed the title
Contributor
Author
|
Closing as this was addressed via: podman-container-tools/podman#4215 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--squash-allflag that will be unique topodman buildand will notbe used by Buildah.
buildah bud --layers=falseis equivalent todocker build --squash(experimental). When a podman build command includes the--squashoption, podman will translate that to--layers=falsefor the buildah bud api code. Adocker buildcall is equivalent topodman buildorpodman build --layers=trueand that's not changing.When podman build uses the
--squash-allcommand, it will turn on the --squash option for the buildah bud api to have only one layer returned by the buildah bud code. There's not a Docker equivalent for this at the moment.I'll hopefully be spinning up a Podman PR in the next day or two that will use this new option.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com