Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Replace Laravel Mix with Vite #1509

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eteubert
Copy link
Member

We use Laravel Mix to bundle the legacy js in the js directory. However, that project is abandoned. And there is security issue in a sub dependency (webpack) that needs to be fixed. The quick fix would be to bump webpack in the lock file, but eventually we need to get rid of it. This is the exploration.

Lots of weirdness in the legacy code:

  • some dependencies were copied in the source tree instead of an npm dep
  • some of the code is dead, but figuring out what can be removed is for another day (except some very obvious cases)
  • very strange JS module code in combination with var PODLOVE = PODLOVE || {}; as a global space hack.

Eventually all of this should move and/or be rewritten to the new codebase. But let's see how far I get with duct tape before we start another months-long transitioning journey.

@eteubert
Copy link
Member Author

Not sure if I should put more time into this or abandon until we eventually move it to the new architecture bit by bit.

Everytime I feel like I'm getting closer there's another lib I need to update a major version or two, which needs syntax updates, then something doesn't quite work, etc. Felt like I was at 80%, then I put in another few hours, and I'm still at 80%. Not sure if it's worth it to keep going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant