Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code #4426

Closed
aleks-f opened this issue Jan 30, 2024 · 2 comments · Fixed by #4551
Closed

Remove deprecated code #4426

aleks-f opened this issue Jan 30, 2024 · 2 comments · Fixed by #4551
Assignees
@matejk
Labels
breaking A breaking change fixed release
Milestone
Release 1.14.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Jan 30, 2024 •
edited by matejk
Loading

All deprecated code should be removed.

List of deprecated items:

Data:

  • SQLParser::parseSQLString
  • RecordSet::totalRowCount
  • SQLChannel::PROP_ASYNC

Foundation:

  • AbstractObserver::accepts(Notification* pNf, const char* pName)
  • DirectorySeparator::operator++ (postfix operator)
  • Dynamic::Var::empty
  • DynamicAny
  • Event::Event(bool autoReset)
  • FIFOEvent
  • FIFOStrategy
  • HashFunction
  • HashStatistic
  • HashTable
  • NObserver::accepts(Notification* pNf, const char* pName)
  • NumericString::uIntToStr
  • Observer::accepts(Notification* pNf, const char* pName)
  • SimpleHashTable

Net:

  • HTTPResponse::HTTP_USEPROXY
  • HTTPResponse::HTTP_REQUESTENTITYTOOLARGE
  • HTTPResponse::HTTP_REQUESTURITOOLONG
  • HTTPResponse::HTTP_UNSUPPORTEDMEDIATYPE
  • NetworkInterface::NetworkInterfaceList
  • Socket::select

Applications can define POCO_SILENCE_DEPRECATED to disable Poco deprecation warnings if needed.
@aleks-f aleks-f added breaking A breaking change release labels Jan 30, 2024
@aleks-f aleks-f added this to the Release 1.14.0 milestone Jan 30, 2024
@aleks-f aleks-f added this to 1.14 Jan 30, 2024
@matejk
Copy link
Contributor

matejk commented Jan 30, 2024

Does everything labelled with @deprecated or [[deprecated]] qualify for removal?

@obiltschnig
Copy link
Member

Maybe, as a first step, change everything marked //@ deprecated to [[deprecated]] so that everyone has a chance to fix their code.

@matejk matejk moved this to In Progress in 1.14 Feb 1, 2024
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
64f14d4 
)
@matejk matejk mentioned this issue May 8, 2024
Merged
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
c46e0f3 
)
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
5636cad 
)
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
343d214 
)
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
60ed084 
)
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
e844eb9 
)
matejk added a commit that referenced this issue May 8, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
481d3b1 
)
matejk added a commit that referenced this issue May 9, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
a2e0a31 
)
matejk added a commit that referenced this issue May 9, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
181c9af 
)
matejk added a commit that referenced this issue May 9, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
4498860 
)
matejk added a commit that referenced this issue May 9, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
ffd385c 
)
matejk added a commit that referenced this issue May 9, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
888770a 
)
matejk added a commit that referenced this issue May 10, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
ca789df 
)
matejk added a commit that referenced this issue May 10, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
3a8489f 
)
matejk added a commit that referenced this issue May 10, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
d3cf834 
)
matejk added a commit that referenced this issue May 10, 2024
@matejk
enh: Code improvements done while resolving deprecated functionality (#…
a8829be 
…4426)
matejk added a commit that referenced this issue May 10, 2024
@matejk
enh: Code improvements done while resolving deprecated functionality (#…
bc4b50a 
…4426)
matejk added a commit that referenced this issue May 13, 2024
@matejk
enh: Code improvements done while resolving deprecated functionality (#…
3999dcd 
…4426)
matejk added a commit that referenced this issue May 24, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
5d0fcce 
)
matejk added a commit that referenced this issue May 24, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
e7206f9 
)
matejk added a commit that referenced this issue May 24, 2024
@matejk
enh: Code improvements done while resolving deprecated functionality (#…
1e6057b 
…4426)
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
3cc3f4e 
)
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
enh: Code improvements done while resolving deprecated functionality (#…
b1cbbfa 
…4426)
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
Un-deprecate LocalDateTme (#4426)
fe5f2b5
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
enh(Poco): Replace usage of deprecated functionality with other funct…
e5ee176 
…ions/classes (#4426)
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
chore(SSL): temporarily un-deprecate SSL-related functionality (#4426)
afaa1e6
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
chore(SSL): temporarily un-deprecate old MongoDB protocol functionali…
99f97ea 
…ty (#4426)
matejk added a commit that referenced this issue Jul 12, 2024
@matejk
enh(Poco): Minor Hash improvements (#4426)
282b6d5
matejk added a commit that referenced this issue Jul 15, 2024
@matejk
enh(Foundation): Compile deprecated hash tests only when POCO_TEST_DE…
1f7b05f 
…PRECATED is enabled (#4426)
matejk added a commit that referenced this issue Jul 15, 2024
@matejk
enh(Net): Compile deprecated Socket::select functionality only when P…
40fdf5c 
…OCO_TEST_DEPRECATED is enabled (#4426)
matejk added a commit that referenced this issue Jul 15, 2024
@matejk
enh(Bonjour): Replace deprecated Socket::select with PollSet (#4426)
105597b
This was referenced Jul 15, 2024
Open
Closed
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Poco): Replace some deprecated functionality in Poco sources. (#4426
4d4f2bf 
)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Poco): Replace more deprecated functionality in Poco sources. (#4426
e87a2d9 
)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh: Code improvements done while resolving deprecated functionality (#…
e9b26ee 
…4426)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
Un-deprecate LocalDateTme (#4426)
c4e01e1
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Poco): Replace usage of deprecated functionality with other funct…
5587305 
…ions/classes (#4426)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
chore(SSL): temporarily un-deprecate SSL-related functionality (#4426)
f8c0ce0
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
chore(SSL): temporarily un-deprecate old MongoDB protocol functionali…
5d72939 
…ty (#4426)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Poco): Minor Hash improvements (#4426)
2e9cb49
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Foundation): Compile deprecated hash tests only when POCO_TEST_DE…
f9fc941 
…PRECATED is enabled (#4426)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Net): Compile deprecated Socket::select functionality only when P…
0df7424 
…OCO_TEST_DEPRECATED is enabled (#4426)
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Bonjour): Replace deprecated Socket::select with PollSet (#4426)
671c8a9
matejk added a commit that referenced this issue Jul 25, 2024
@matejk
enh(Poco): Introduce POCO_DEPRECATED macro to have the ability to dis…
ad8c34f 
…able deprecation warnings in applications (#4426)
matejk added a commit that referenced this issue Jul 29, 2024
@matejk @aleks-f
Mark deprecated functionality with C++ attributes and resolve interna…
91bea7c 
…l usage of deprecated functions (#4551)

* enh(poco): Replace deprecated comments with C++ deprecated attribute.

* enh(Poco): Replace some deprecated functionality in Poco sources. (#4426)

* enh(Poco): Replace more deprecated functionality in Poco sources. (#4426)

* fix(CMake): Variable BUILD_SHARED_LIBS must be defined properly to create valid binaries.

* enh: Code improvements done while resolving deprecated functionality (#4426)

* Un-deprecate LocalDateTme (#4426)

* enh(Poco): Replace usage of deprecated functionality with other functions/classes (#4426)

* chore(SSL): temporarily un-deprecate SSL-related functionality (#4426)

* chore(SSL): temporarily un-deprecate old MongoDB protocol functionality (#4426)

* enh(Poco): Minor Hash improvements (#4426)

* enh(Foundation): Compile deprecated hash tests only when POCO_TEST_DEPRECATED is enabled (#4426)

* enh(Net): Compile deprecated Socket::select functionality only when POCO_TEST_DEPRECATED is enabled (#4426)

* enh(Bonjour): Replace deprecated Socket::select with PollSet (#4426)

* enh(Poco): Introduce POCO_DEPRECATED macro to have the ability to disable deprecation warnings in applications (#4426)

* test(ODBC): add few asserts to testStoredProcedureDynamicVar

* fix(ODBC): rename DynamicAny -> DynamicVar in tests

* fix(ODBC): make Dignostics static members inline to prevent explicit instantiation warnings on windows

---------

Co-authored-by: Alex Fabijanic <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.14 Jul 29, 2024
matejk added a commit that referenced this issue Jul 29, 2024
@matejk @aleks-f
enh(Poco): Mark deprecated functionality with C++ attributes and reso…
f24547c 
…lve internal usage of deprecated functions (#4551)

* enh(poco): Replace deprecated comments with C++ deprecated attribute.

* enh(Poco): Replace some deprecated functionality in Poco sources. (#4426)

* enh(Poco): Replace more deprecated functionality in Poco sources. (#4426)

* fix(CMake): Variable BUILD_SHARED_LIBS must be defined properly to create valid binaries.

* enh: Code improvements done while resolving deprecated functionality (#4426)

* Un-deprecate LocalDateTme (#4426)

* enh(Poco): Replace usage of deprecated functionality with other functions/classes (#4426)

* chore(SSL): temporarily un-deprecate SSL-related functionality (#4426)

* chore(SSL): temporarily un-deprecate old MongoDB protocol functionality (#4426)

* enh(Poco): Minor Hash improvements (#4426)

* enh(Foundation): Compile deprecated hash tests only when POCO_TEST_DEPRECATED is enabled (#4426)

* enh(Net): Compile deprecated Socket::select functionality only when POCO_TEST_DEPRECATED is enabled (#4426)

* enh(Bonjour): Replace deprecated Socket::select with PollSet (#4426)

* enh(Poco): Introduce POCO_DEPRECATED macro to have the ability to disable deprecation warnings in applications (#4426)

* test(ODBC): add few asserts to testStoredProcedureDynamicVar

* fix(ODBC): rename DynamicAny -> DynamicVar in tests

* fix(ODBC): make Dignostics static members inline to prevent explicit instantiation warnings on windows

---------

Co-authored-by: Alex Fabijanic <[email protected]>
@matejk matejk added the fixed label Sep 20, 2024
matejk added a commit that referenced this issue Nov 30, 2024
@matejk
enh(MongoDB): handle deprecated functionality (#4426)
f97bf7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejk matejk

Labels
breaking A breaking change fixed release
Projects
1.14
Status: Done
Milestone
Release 1.14.0
3 participants
@obiltschnig @matejk @aleks-f