#include changes and header files for multiple source files #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably fine, I haven't looked into it much, but if it was up to me I'd just get rid of the ALLINONE feature completely. That should simplify the code and make it more maintainable/malleable for the future. As mentioned issue #38 you can get a similar effect in a much nicer way by simply compiling with |
Certainly, I did this to simplify extending this functionality should it be desirable to be kept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how files are included when ALLINONE is defined to make extending this functionality to new source files easier. A new
export.hhas been created to enable easier use of theEXPORTmacro. Furthermore, header files have been created forinit.c,output.c, and the hashing related source files.