Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Validate decimals in step two #772

Merged
merged 57 commits into from
Apr 10, 2018
Merged

(Fix) Validate decimals in step two #772

merged 57 commits into from
Apr 10, 2018

Conversation

fernandomg
Copy link
Contributor

@fernandomg fernandomg commented Apr 6, 2018 •
edited
Loading

Closes #769

This PR depends on #767.

This PR commits:

Franco Victorio and others added 30 commits March 27, 2018 16:37
WIP
568d4c0
Migrate step three form to final-form
488f8e0
Custom GasPriceInput component
de0d86a
@fernandomg
Merge remote-tracking branch 'origin/use-final-form-step-three' into …
ec5445b 
…use-final-form-step-three

# Conflicts:
#	src/components/stepThree/index.js
Add whitelist block
b883253
@fernandomg
Merge remote-tracking branch 'origin/use-final-form-step-three' into …
6837eb4 
…use-final-form-step-three
@fernandomg
Set initial value for wallet address
02bf232
@fernandomg
Set minCap default value to empty string
c1f7cec
@fernandomg
Move add tier button to 'button-container' block
f174929
@fernandomg
Use GasPriceStore values
8f719df
@fernandomg
Use constant values for CUSTOM field
2ff0719
@fernandomg
Unified radios block
050b458
@fernandomg
Fix custom gas input styles
3064fb7
@fernandomg
Add loading overlay
cae8cea
@fernandomg
Fix Tier dates initialization
c302fc1
@fernandomg
Add ability to display an array of error messages
5d2c38d
@fernandomg
Extend validations and tests
9a2aadf
@fernandomg
Add react-final-form-listener as a dependency
827fb64
@fernandomg
Create WhenFieldChanges component
48431ac
@fernandomg
Add validations for minCap
a912198
@fernandomg
Add rate validations
a718172
@fernandomg
Set minCap to 0 (zero) when whitelist is enabled
cc8093f
@fernandomg
Remove 'instant' from collection of Gas Prices
2ba546f
@fernandomg
Add gasPricesInGwei computed method
e75b002
@fernandomg
Create 'Error' component for final-form error display
501a58e
@fernandomg
Modify InputField2 to use Error component
975db02
@fernandomg
Add Error component to GasPriceInput
dd4d2f2
@fernandomg
Modify customGasPrice initial value
1996ca0
@fernandomg
Add isGreaterOrEqualThan validation
529364c
@fernandomg
Validate Custom GasPrice
520be8e
@ghost ghost assigned fernandomg Apr 6, 2018
@ghost ghost added the in progress label Apr 6, 2018
@fernandomg fernandomg changed the title (Fix) Validate decimals step two #769 (Fix) Validate decimals in step two Apr 6, 2018
@fernandomg
Copy link
Contributor Author

fernandomg commented Apr 6, 2018 •
edited
Loading

@dennis00010011b Please, take a look at this test (use the same criteria for the error selection using the className)

@ghost ghost added the in progress label Apr 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1904

  • 63 of 211 (29.86%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 19.597%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Common/WhenFieldChanges.js 0 7 0.0%
src/stores/TierStore.js 0 16 0.0%
src/components/stepThree/index.js 0 22 0.0%
src/components/stepThree/GasPriceInput.js 0 28 0.0%
src/components/Common/TierBlock.js 0 35 0.0%
src/components/stepThree/StepThreeForm.js 0 40 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/stepThree/index.js 3 0.0%
Totals Coverage Status
Change from base Build 1883: 1.2%
Covered Lines: 538
Relevant Lines: 2382
💛 - Coveralls

@fernandomg fernandomg requested review from fvictorio and vbaranov and removed request for fvictorio April 6, 2018 19:21
@vbaranov vbaranov merged commit 31c3a22 into master Apr 10, 2018
@ghost ghost removed the awaiting for review label Apr 10, 2018
@vbaranov vbaranov deleted the validate-decimals-stepTwo-#769 branch April 10, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

Assignees

@fernandomg fernandomg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernandomg @coveralls @vbaranov