-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Fix) Cast to bigNumber values returned by contracts #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1752
💛 - Coveralls |
vbaranov
reviewed
Mar 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fernandomg the changes fix the issue, but maybe we can force convert input to string here
const number = new BigNumber(value) |
@vbaranov
I can make that conversion, but will be redundant and unnecessary in this case. |
vbaranov
approved these changes
Mar 16, 2018
ghost
removed
the
awaiting for review
label
Mar 16, 2018
This was referenced Apr 3, 2020
This was referenced Apr 7, 2021
This was referenced May 6, 2021
This was referenced May 25, 2021
This was referenced Sep 12, 2021
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #706
In spite of what's pointed out in the bug details, this bug was caused by treating values returned by contracts as numbers and not as
bigNumber
.There were values not being properly converted:
weiRaised
andtokensSold
. And to prevent any possible issue, I also did changes toinvestors
.