Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) display wallet address in all tiers #701

Merged
merged 2 commits into from
Mar 15, 2018

Conversation

fernandomg
Copy link
Contributor

@fernandomg fernandomg commented Mar 15, 2018

Relates #673

As per @fvictorio comment (#673 (comment)), all tiers should display the wallet address.

@coveralls
Copy link

coveralls commented Mar 15, 2018

Pull Request Test Coverage Report for Build 1731

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 15.641%

Totals Coverage Status
Change from base Build 1726: 0.008%
Covered Lines: 388
Relevant Lines: 1980

💛 - Coveralls

Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fernandomg I approve this PR as a temporary solution to fill the empty fields, but I agree with @fvictorio #673 (comment), that wallet address should be the global configuration of a crowdsale, not a tier.

@vbaranov vbaranov merged commit 167b7a9 into master Mar 15, 2018
@vbaranov vbaranov deleted the display-wallet-address-for-tiers-stepfour-#673 branch March 15, 2018 19:28
@ghost ghost removed the awaiting for review label Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants