Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) e2e tests with current changes on local deployment in Travis CI #698

Merged
merged 8 commits into from
Mar 15, 2018

Conversation

vbaranov
Copy link
Collaborator

@vbaranov vbaranov commented Mar 15, 2018

Relates to poanetwork/token-wizard-test-automation#17
e2e tests with current changes on local deployment in Travis CI

@ghost ghost assigned vbaranov Mar 15, 2018
@ghost ghost added the in progress label Mar 15, 2018
@coveralls
Copy link

coveralls commented Mar 15, 2018

Pull Request Test Coverage Report for Build 1715

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 15.634%

Files with Coverage Reduction New Missed Lines %
src/utils/alerts.js 2 0.0%
src/stores/ReservedTokenStore.js 3 11.54%
src/components/stepTwo/index.js 31 0.0%
Totals Coverage Status
Change from base Build 1693: 0.05%
Covered Lines: 388
Relevant Lines: 1980

💛 - Coveralls

.travis.yml Outdated
@@ -6,7 +6,6 @@ install:
- npm install

before_script:
- npm run installWeb3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may break the unit tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this will work because npm test runs the e2e tests first, and the e2e-prepare-start script installs web3. This makes the tests order-dependent, but it's not a big deal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvictorio you are right. It is better to leave in .travis.yml. I'll redefine e2e-prepare-start script instead.

@vbaranov
Copy link
Collaborator Author

@dennis00010011b please let us know when e2e tests will be fixed. Then we will be able to merge this PR. And after it, e2e tests will be launching on the version of Wizard in PR, not on production link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants