Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Deployment progress feedback to the user #503

Merged
merged 14 commits into from
Jan 26, 2018

Conversation

fernandomg
Copy link
Contributor

@fernandomg fernandomg commented Jan 18, 2018

This is the first step towards the completion of #464

Presents a list of the required Txs and its statuses during crowdsale deployment.
Please check the steps' descriptions.

image

Copy link
Contributor

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job

@vbaranov
Copy link
Collaborator

@fernandomg could you please resolve conflicts?

@fernandomg
Copy link
Contributor Author

@vbaranov done

Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

There is one UI bag with multiple tiers:

screen shot 2018-01-26 at 14 00 17

Maybe, modify to: always in the same line with the horizontal scroll?

@fvictorio
Copy link
Contributor

@vbaranov I tried to add a horizontal scroll but it turned out to be way harder than I thought, because the table is made with flexbox so adding a scrollbar is not as straightforward as doing overflow-x: auto.

I'd say we merge this and open a new issue for that bug, so that this feature is merged for today's demo. What do you think?

@vbaranov
Copy link
Collaborator

Ok, let's go this way.

@vbaranov vbaranov self-requested a review January 26, 2018 13:26
@vbaranov vbaranov merged commit 680f782 into master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants