Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Change Whitelist Disabled to Whitelist Enabled #443

Merged
merged 5 commits into from
Jan 17, 2018
Merged

(Feature) Change Whitelist Disabled to Whitelist Enabled #443

merged 5 commits into from
Jan 17, 2018

Conversation

fernandomg
Copy link
Contributor

Closes #440

@fernandomg fernandomg self-assigned this Jan 4, 2018
@BlackDuckCoPilot
Copy link

Black Duck Security Report

Merging #443 into master will decrease security risk!

Added Components

Medium Risk: 1
Clean: 1360

Click here to see full report

vbaranov
vbaranov approved these changes Jan 4, 2018
View reviewed changes
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes affected code semantic mostly.
After implementation, the code will be more human-readable in part of the "whitelist enabling" feature.

@ghost ghost assigned vbaranov Jan 12, 2018
@fvictorio
Copy link
Contributor

I'm getting an error trying to start the app in this branch:

Failed to compile
./src/components/manage/utils.js
  Line 247:  'whitelisted' is not defined  no-undef

@vbaranov
Copy link
Collaborator

@fvictorio I've updated current branch. Perhaps, the error is from manual conflicts resolving. There is shouldn't be this error now.

@fvictorio
Copy link
Contributor

I can't properly test this because the invest is not working, see #498.

@ghost ghost assigned fvictorio Jan 16, 2018
@fvictorio
Copy link
Contributor

I changed the wording of the whitelist label. @vbaranov, if you think that's ok, please merge this.

@vbaranov vbaranov merged commit 5ee348b into master Jan 17, 2018
@ghost ghost removed the awaiting for review label Jan 17, 2018
@vbaranov vbaranov deleted the whitelisting-message branch January 17, 2018 10:35
@kinexis-uk kinexis-uk mentioned this pull request Nov 5, 2022
Open
@cleancoindev cleancoindev mentioned this pull request Nov 5, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Nov 5, 2022
Open
@kinexis-uk kinexis-uk mentioned this pull request Dec 25, 2022
Open
@cleancoindev cleancoindev mentioned this pull request Dec 25, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@fvictorio fvictorio fvictorio approved these changes

@igorbarinov igorbarinov Awaiting requested review from igorbarinov

Assignees

@fvictorio fvictorio

@fernandomg fernandomg

@vbaranov vbaranov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernandomg @BlackDuckCoPilot @fvictorio @vbaranov