Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Download contract on user request #344

Merged
merged 5 commits into from
Nov 8, 2017

Conversation

fernandomg
Copy link
Contributor

Closes #271
Depends on and fixes #340

For #340:

  • Moved AlertContainer to App container to easier reuse
  • Created toast util and TOASTconstant with default information
  • Moved strings to constants

For #271

  • Displays a Toast notifying the user that the Contract was downloaded.

  • Removed automatic Contract download

  • Download Contract on demand (by clicking the button + Download File)
    download-contract-on-demand

  • Download Contract, if it wasn't downloaded, when the user clicks Continue
    download-contract-on-continue

Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fernandomg Fernando, please, resolve some conflicts with master branch

@fernandomg
Copy link
Contributor Author

@vbaranov conflicts solved

Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested successfully.

@vbaranov
Copy link
Collaborator

vbaranov commented Nov 7, 2017

@igorbarinov @15chrjef any concerns about this PR?

Copy link
Member

@igorbarinov igorbarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change mechanics of file downloading for a file with contracts
3 participants