Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) metadata should be added to zip archive for download #1125

Merged
merged 2 commits into from
Sep 5, 2018
Merged

(Feature) metadata should be added to zip archive for download #1125

merged 2 commits into from
Sep 5, 2018

Conversation

mariano-aguero
Copy link
Contributor

Closes #1041

@mariano-aguero mariano-aguero added this to the 2.0 milestone Sep 4, 2018
@mariano-aguero mariano-aguero self-assigned this Sep 4, 2018
@dennis00010011b
Copy link

dennis00010011b commented Sep 4, 2018 •
edited
Loading

@mariano-aguero
typo in files with metadata (both Minted and Dutch)
Should be 'parameters'
screen shot 2018-09-04 at 9 35 44 pm

@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 3040

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 19.934%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/stepFour/utils.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/stepFour/utils.js 1 0.0%
Totals Coverage Status
Change from base Build 3030: -0.006%
Covered Lines: 884
Relevant Lines: 3803
💛 - Coveralls

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

typo in files with metadata

Fix typo

@mariano-aguero mariano-aguero merged commit e6a972a into 2.0 Sep 5, 2018
@ghost ghost removed the awaiting for review label Sep 5, 2018
@mariano-aguero mariano-aguero deleted the issue#1041 branch September 5, 2018 12:13
@kinexis-uk kinexis-uk mentioned this pull request Nov 5, 2022
Open
@cleancoindev cleancoindev mentioned this pull request Nov 5, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Nov 5, 2022
Open
@kinexis-uk kinexis-uk mentioned this pull request Dec 25, 2022
Open
@cleancoindev cleancoindev mentioned this pull request Dec 25, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennis00010011b dennis00010011b dennis00010011b approved these changes

@vbaranov vbaranov vbaranov approved these changes

@fernandomg fernandomg Awaiting requested review from fernandomg

Assignees

@mariano-aguero mariano-aguero

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mariano-aguero @dennis00010011b @coveralls @vbaranov