-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) New design for home / landing page #1122
(Feature) New design for home / landing page #1122
Conversation
(Bug) Keep data between the steps (Step 1)
(Bug) Keep data between the steps (Step 2)
For now this popup it's just restyled like the modal windows in the new designs. |
…-new-design-step-1 * feature/#1084-new-design-landing-page: (179 commits) (fix) Firefox button borders. (feedback) Various fixes and changes from #1122 Remove conditional Add proxyName, compiler version and optimization info Set ABI-Encoded Params to Proxy constructor params Add source code of smart proxy contract to zip archive for download Change how validate params and network id Check crowdsale env vars by crowdsale type Add ABI-Encoded params Added new contracts keys to file Remove unused function Refactoring function Update snapshot Reload storage on home Remove ABI source code Change label on content file Remove bin from summary Add function import Sort crowdsales list Add clear storage on manage section ... # Conflicts: # src/assets/stylesheets/styles.css
@gabitoesmiapodo everything fixed. Now the main-info box is not properly aligned vertically (in both, firefox and chrome). It depends on the resolution though because there are cases where it's properly aligned. |
@fernandomg @gabitoesmiapodo Sorry for confusion. I am not about the list of steps in the left menu or changing the logic. I am just talking about the representation of the modal window. From this PR it looks like But from the layout it should be like: But I am sure, that it could be made in a separate PR and it shouldn't stop to merge this one. |
@fernandomg I think it might be that you are forgetting to add the ?uiversion=2 parameter? That's what happens to me, at least. Added a few CSS improvements anyway, just in case. If that's not the case I will need some more info, as screen resolution, etc. I just adapted the general modal windows and tables styles to look like this https://zpl.io/2ymGX4n and that's why it looks that way now. But that will not be the final implementation. That said, it will be necessary more than a simple modal restyling to make this: https://zpl.io/blpk4Q0 (or this, I'm not sure which design should be implemented, or if this is a different section... but both are very alike) https://zpl.io/brNpKB7 because it changes completely what we have now, and that's why I think it would be better to implement that feature in a new issue. |
@gabitoesmiapodo ok, let's leave it as is for now. Representation of this modal window needs to be discussed with a designer... |
- added method to handle navigation to facilitate testing
I've added tests for the Updated tests for Also modified All test cases related to There's a test case that failed and due to time constraints, I decided to create a separate issue (#1129) to solve it as it's taking too much time. |
Description:
Implemented the new designs for the Token Wizard's home page, and also some common elements like modal windows, and a full screen loading component.
Notes:
Designs (Zeplin):
Some screenshots:
Desktop:
Tablet:
Mobile: