Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Add ABI-Encoded params for Proxy Contracts #1120

Merged
merged 2 commits into from
Sep 4, 2018
Merged

(Feature) Add ABI-Encoded params for Proxy Contracts #1120

merged 2 commits into from
Sep 4, 2018

Conversation

fernandomg
Copy link
Contributor

Closes #1038

@fernandomg fernandomg self-assigned this Aug 31, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3005

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 20.314%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/stepFour/index.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/stepFour/index.js 1 0.0%
Totals Coverage Status
Change from base Build 2996: -0.02%
Covered Lines: 834
Relevant Lines: 3597
💛 - Coveralls

@dennis00010011b
Copy link

@fernandomg
I can't verify contract with ABI-encoded parameters from publish page. Error received in Ropsten etherscan : Error! Invalid constructor arguments provided. Please verify that they are in ABI-encoded format. I have tried both for Minted and Dutch strategy

Network: Ropsten

Crowdsale Proxy Address: 0x5c13db37d7ef917291e51a9a1f50c45178a15edd (Dutch)
https://ropsten.etherscan.io/address/0x5c13db37d7ef917291e51a9a1f50c45178a15edd

ABI-Encoded (copied from Publish page):

0x00000000000000000000000056b2e3c3cff7f3921dc2e0f8b8e20d1eec29216b00000000000000000000000000000000000000000000003635c9adc5dea0000000000000000000000000000000000000000000000000000ad78ebc5ac6200000000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000000038d7ea4c68000000000000000000000000000000000000000000000000000000000000004c7ac000000000000000000000000000000000000000000000000000000005b8c08c4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000056b2e3c3cff7f3921dc2e0f8b8e20d1eec29216b0000000000000000000000000000000000000000000000000000000000000000

screen shot 2018-09-02 at 9 02 43 am

@fernandomg
Copy link
Contributor Author

Thanks for the review @dennis00010011b. It's fixed now.

Keep in mind to properly set the Compiler and Optimization options properly.

image

Thanks @vbaranov for the clarification.

@vbaranov vbaranov merged commit a54838d into 2.0 Sep 4, 2018
@ghost ghost removed the awaiting for review label Sep 4, 2018
@vbaranov vbaranov deleted the add-abi-encoded-params-#1038 branch September 4, 2018 08:15
@kinexis-uk kinexis-uk mentioned this pull request Nov 5, 2022
Open
@cleancoindev cleancoindev mentioned this pull request Nov 5, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Nov 5, 2022
Open
@kinexis-uk kinexis-uk mentioned this pull request Dec 25, 2022
Open
@cleancoindev cleancoindev mentioned this pull request Dec 25, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennis00010011b dennis00010011b dennis00010011b approved these changes

@vbaranov vbaranov vbaranov approved these changes

@mariano-aguero mariano-aguero mariano-aguero approved these changes

Assignees

@fernandomg fernandomg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fernandomg @coveralls @dennis00010011b @mariano-aguero @vbaranov