(Feature) Add assets to support new design #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gabitoesmiapodo
changed the title
Pull Request Test Coverage Report for Build 2987
💛 - Coveralls |
vbaranov
approved these changes
Aug 31, 2018
There was a problem hiding this comment.
@gabitoesmiapodo a plan of implementing restyling step by step looks good to me.
|
@dennis00010011b could we in parallel with restyling update, also updating e2e tests to support new interface? |
|
@vbaranov |
fernandomg
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pull request to temporary branch origin/integration/#1082-new-design where we can continually merge the latest "new styling" working branches (#1083, #1084, etc.), and the 2.0 PRs, so as to keep everything as updated as possible.
As for the #1083 tasks: I don't think that extracting and adding all the new assets is the best thing to do at this step, so I will be doing that screen by screen / component by component, unless somebody needs some asset to do their job.
How to test:
1- There should be some new folders and files, preparing the terrain for the new styles, check that those exist:
token-wizard/src/assets/stylesheets/v2.0 contains some new folders, files, and explanations.
token-wizard/src/assets/images/v2.0 has some folders and images for the new styles
This structure will allow us to have the old and new styles in parallel, minimizing the risk of losing something currently working. Once the work is finished, we'll delete the old files and that's it.
2- It's possible to switch styles using:
http://dappurl/?uiversion=2 (v2, currently ugly and broken)
http://dappurl/?uiversion=1 (v1 working version)
http://dappurl/ a mix of versions 1 and 2, to compensate for whatever styles are not done yet.
This should work.
When we finish we will also delete the old styles.