Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Add selector 'id' to all DOM input elements #1031

Merged
merged 1 commit into from
Jul 12, 2018
Merged

(Feature) Add selector 'id' to all DOM input elements #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Common/InputField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const InputField = props => {
<div className={props.side}>
<label className="label">{props.title}</label>
<input
id={props.name}
disabled={props.disabled}
type={props.type}
className="input"
Expand Down
3 changes: 2 additions & 1 deletion src/components/Common/NumericInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,13 @@ export class NumericInput extends Component {

render() {
const { value, pristine, valid } = this.state
const { disabled, side, errorMessage, title, description } = this.props
const { disabled, side, errorMessage, title, description, name } = this.props

return (
<InputField
disabled={disabled}
side={side}
name={name}
type="number"
errorMessage={errorMessage}
value={value}
Expand Down
8 changes: 7 additions & 1 deletion src/components/Common/RadioInputField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ import '../../assets/stylesheets/application.css'
export const RadioInputField = props => {
const inputs = props.items.map((item, index) => (
<label className="radio-inline" key={index}>
<input type="radio" checked={props.selectedItem === item.value} onChange={props.onChange} value={item.value} />
<input
type="radio"
id={item.value}
checked={props.selectedItem === item.value}
onChange={props.onChange}
value={item.value}
/>
<span className="title">{item.label}</span>
</label>
))
Expand Down
2 changes: 2 additions & 0 deletions src/components/Common/ReservedTokensInputBlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ export class ReservedTokensInputBlock extends Component {
side="reserved-tokens-input-property reserved-tokens-input-property-left"
type="text"
title={ADDRESS}
name={ADDRESS}
value={this.state.addr}
onChange={e => this.handleAddressChange(e.target.value)}
description="Address where to send reserved tokens."
Expand All @@ -240,6 +241,7 @@ export class ReservedTokensInputBlock extends Component {
<NumericInput
side="reserved-tokens-input-property reserved-tokens-input-property-right"
title={VALUE}
name={VALUE}
value={this.state.val}
pristine={this.state.validation.value.pristine}
valid={this.state.validation.value.valid}
Expand Down
6 changes: 6 additions & 0 deletions src/components/Common/TierBlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export const TierBlock = ({ fields, ...props }) => {
<div className="hidden">
<div className="input-block-container">
<Field
id={`${name}.tier`}
name={`${name}.tier`}
validate={value => {
const errors = composeValidators(isRequired(), isMaxLength()(30))(value)
Expand All @@ -45,13 +46,15 @@ export const TierBlock = ({ fields, ...props }) => {

<div className="input-block-container">
<Field
id={`${name}.updatable`}
name={`${name}.updatable`}
render={({ input }) => (
<div className="left">
<label className="label">{ALLOW_MODIFYING}</label>
<div className="radios-inline">
<label className="radio-inline">
<input
id={`${name}.allow_modifying_on`}
type="radio"
checked={input.value === 'on'}
onChange={() => input.onChange('on')}
Expand All @@ -61,6 +64,7 @@ export const TierBlock = ({ fields, ...props }) => {
</label>
<label className="radio-inline">
<input
id={`${name}.allow_modifying_off`}
type="radio"
checked={input.value === 'off'}
value="off"
Expand All @@ -82,6 +86,7 @@ export const TierBlock = ({ fields, ...props }) => {
<div className="radios-inline">
<label className="radio-inline">
<input
id={`${name}.enable_whitelisting_yes`}
type="radio"
checked={input.value === 'yes'}
value="yes"
Expand All @@ -91,6 +96,7 @@ export const TierBlock = ({ fields, ...props }) => {
</label>
<label className="radio-inline">
<input
id={`${name}.enable_whitelisting_no`}
type="radio"
checked={input.value === 'no'}
value="no"
Expand Down
1 change: 1 addition & 0 deletions src/components/manage/ManageForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export const ManageForm = inject('tokenStore', 'generalStore', 'crowdsaleStore')
side={crowdsaleStore.isDutchAuction ? 'right' : 'left'}
type="text"
title={TEXT_FIELDS.WALLET_ADDRESS}
name="walletAddress"
value={tiers[0].walletAddress}
disabled={true}
/>
Expand Down
9 changes: 8 additions & 1 deletion src/components/manage/ManageTierBlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,14 @@ export const ManageTierBlock = inject('crowdsaleStore', 'tokenStore')(
<div className="steps-content container">
<div className={classNames('hidden', { divisor: isWhitelistEnabled })}>
<div className="input-block-container">
<InputField side="left" type="text" title={CROWDSALE_SETUP_NAME} value={tier} disabled={true} />
<InputField
side="left"
type="text"
title={CROWDSALE_SETUP_NAME}
name={`${name}.crowdsale_name`}
value={tier}
disabled={true}
/>
</div>

<div className="input-block-container">
Expand Down
2 changes: 2 additions & 0 deletions src/components/stepThree/GasPriceInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class GasPriceInput extends Component {
<div key={index} className="radios-inline">
<label className="radio-inline">
<input
id={gasPrice.id}
type="radio"
checked={input.value.id === gasPrice.id}
onChange={() => {
Expand All @@ -86,6 +87,7 @@ class GasPriceInput extends Component {
))}
{this.state.isCustom ? (
<input
id="customGasPrice"
type="number"
className="input"
value={this.state.customGasPrice}
Expand Down