(Fix, Sokol) Disable EIP-1283 in Sokol#105
Merged
Merged
Conversation
phahulin
changed the title
phahulin
approved these changes
Jan 21, 2019
Contributor
phahulin
left a comment
phahulin
left a comment
There was a problem hiding this comment.
I changed the title a little bit, so that we don't merge it by mistake before time comes :)
|
merged see also ethereum/EIPs#1716 |
Contributor
|
Should we wait for ethereum/EIPs#1642 (comment) until this bug report is accepted or rejected? (how do we find out btw?) |
|
It's false alarm, @phahulin |
varasev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update disables Constantinople EIP-1283 in
spec.jsonforSokolnetwork which was introduced in #91.The block number
7026400(6 February, 12:00 UTC).Should be merged after openethereum/parity-ethereum#10223 is merged and a new version of Parity is released.