Skip to content

Move blockGasLimitContract to AuRa params and rename it#189

Merged
afck merged 1 commit into
aura-posfrom
vk-move-block-gas-limit
Aug 30, 2019
Merged

Move blockGasLimitContract to AuRa params and rename it#189
afck merged 1 commit into
aura-posfrom
vk-move-block-gas-limit

Conversation

@vkomenda
Copy link
Copy Markdown

This is a backport from openethereum#10928.

The new name of the parameter is blockGasLimitContractTransitions. @varasev, @phahulin, please use the new name in spec files.

@afck afck merged commit 748a8c7 into aura-pos Aug 30, 2019
@afck afck deleted the vk-move-block-gas-limit branch August 30, 2019 09:20
@afck
Copy link
Copy Markdown
Collaborator

afck commented Aug 30, 2019

@phahulin, @varasev: If I'm reading the code correctly, you also can't specify a single contract address anymore. It has to be a map of block number to contract address.

@varasev
Copy link
Copy Markdown
Member

varasev commented Aug 30, 2019

If I'm reading the code correctly, you also can't specify a single contract address anymore. It has to be a map of block number to contract address.

Yes, we use the map anyway.

@varasev
Copy link
Copy Markdown
Member

varasev commented Aug 30, 2019

I'd propose to merge this after openethereum#10928 is finished because there can be other changes as far as I understand.

@varasev
Copy link
Copy Markdown
Member

varasev commented Aug 30, 2019

I'd propose to merge this after paritytech#10928 is finished because there can be other changes as far as I understand.

Ok, let me first test the new aura-pos with the changed param. If that works fine with posdao-test-setup then OK.

@varasev
Copy link
Copy Markdown
Member

varasev commented Aug 30, 2019

That works fine.

varasev added a commit to poanetwork/posdao-contracts that referenced this pull request Aug 30, 2019
@afck
Copy link
Copy Markdown
Collaborator

afck commented Aug 30, 2019

Sorry for merging early!
I think it's pretty independent of the other potential changes in the upstream PR, though.

@varasev
Copy link
Copy Markdown
Member

varasev commented Aug 30, 2019

I think it's pretty independent of the other potential changes in the upstream PR, though.

Yes, it is. I think we will have to add the same changes in our aura-pos when that PR is merged to upstream.

Oyase-shinobi pushed a commit to Oyase-shinobi/hbbft-posdao-contracts that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants