Compute step and remaining duration from map.#150
Closed
afck wants to merge 1 commit into
Closed
Conversation
vkomenda
reviewed
Jun 19, 2019
|
|
||
| // Our current account nonce. The transactions must have consecutive nonces, starting with this one. | ||
| let mut tx_nonce = block.state.nonce(&our_addr)?; | ||
| let mut tx_nonce = block.state.nonce(&signer.address())?; |
There was a problem hiding this comment.
Why do you think it is better to call address() twice instead of using the reference our_addr?
Collaborator
Author
There was a problem hiding this comment.
Sorry, that was a mistake. I removed this part of the change.
afck
force-pushed
the
afck-step-duration-transition
branch
from
23e17a7 to
6148cfd
Compare
Collaborator
Author
|
The "stepDuration": {
"0": 5,
"312202776": 3
}, |
Member
|
Done in #152. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.