Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CELO chains support #446

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add CELO chains support #446

wants to merge 2 commits into from

Conversation

vbaranov
Copy link
Collaborator

@vbaranov vbaranov commented Feb 9, 2021

Adding native support for CELO token transfers in CELO Mainnet, Alfajores/Baklava Testnets

Related changes in linked packages:

poanetwork/eth-net-props#41 - add basic Celo chains support (Mainnet, Alfajores/Baklava testnets)
poanetwork/eth-net-props#42 - add Celo Alfajores faucet
vbaranov/KeyringController@9f7897a - expose getPrivateKeyFor method to integrate with @celo/contractkit

Transferring CELO via Nifty Wallet:

https://www.loom.com/share/62f163abcec342c7ac24333cb867ce14

@vbaranov vbaranov changed the title Add CELO chain support Add CELO chains support Feb 9, 2021
@@ -25,6 +25,11 @@ const {
TRANSACTION_TYPE_RETRY,
} = require('./enums')

const ContractKit = require('@celo/contractkit')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing commonjs require and es6 import here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, James! I replaced requires with ES6 imports statements in 86a08d0 specifically for TransactionController. Though I am aware, there can be multiple places where mixing takes places in the code. I suppose other mixing occurrences can be processed in a separate refactoring PR(s).

@vbaranov vbaranov marked this pull request as ready for review February 17, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants