Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the decoding #43

Closed
wants to merge 3 commits into from
Closed

fix: improve the decoding #43

wants to merge 3 commits into from

Conversation

hooke007
Copy link
Contributor

@hooke007 hooke007 commented Oct 7, 2022

We do not need much too many threads to decode when requesting.

@hooke007
Copy link
Contributor Author

hooke007 commented Oct 7, 2022


@christoph-heinrich
Copy link
Contributor

It has less cpu usage, but it's also slower.

@hooke007
Copy link
Contributor Author

hooke007 commented Oct 7, 2022

Comparing with the current branch, I didn't notice the diff about the preview presenting.

@christoph-heinrich
Copy link
Contributor

I'm surprised how little difference it makes most of the time, but with something like 4k h265 it becomes very noticeable for me.

multi.thread.mp4
single.thread.mp4

@hooke007
Copy link
Contributor Author

hooke007 commented Oct 7, 2022

How about two threads?

@christoph-heinrich
Copy link
Contributor

threads.2.mp4
threads.3.mp4

@hooke007
Copy link
Contributor Author

hooke007 commented Oct 7, 2022

I added the other solution to reduce the CPU's pressure but faster seeking.

@natural-harmonia-gropius
Copy link
Contributor

Just put default options.hwdec to "no", it's good to be able to modify this. e.g. low-end graphics cards unable to decode two 8k 10bit av1 streams at same time, driver will crash.

@hooke007
Copy link
Contributor Author

hooke007 commented Oct 8, 2022

Isn't it 'no' now?

@natural-harmonia-gropius
Copy link
Contributor

mybad.

@hooke007 hooke007 closed this Oct 29, 2022
@hooke007 hooke007 deleted the sw branch November 1, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants