Skip to content

Use registerHooks for Node v26 compatibility #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
id6tm-mteterel wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

Use registerHooks for Node v26 compatibility #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6bc6b2
fix: use synchronous registerHooks
id6tm-mteterel Jun 23, 2026
adb6627
chore: set minimum node version to 22.15.0
id6tm-mteterel Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions esm_loader.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ const extraNodePaths = (process.env.NODE_PATH || '')
.split(delimiter)
.filter(Boolean)

export async function resolve(specifier, context, defaultResolve) {
export function resolve(specifier, context, nextResolve) {
try {
return await defaultResolve(specifier, context, defaultResolve)
return nextResolve(specifier, context)
} catch (originalError) {
if (specifier.startsWith('.') || specifier.startsWith('/') || specifier.match(/^node:/)) {
// Don't handle relative, absolute, or node: specifiers
Expand All @@ -19,7 +19,7 @@ export async function resolve(specifier, context, defaultResolve) {
const require = createRequire(pathToFileURL(basePath).href)
try {
const resolved = require.resolve(specifier)
return { url: pathToFileURL(resolved).href }
return { url: pathToFileURL(resolved).href, shortCircuit: true }
} catch {
// Skip and try next
}
Expand All @@ -29,4 +29,3 @@ export async function resolve(specifier, context, defaultResolve) {
throw originalError
}
}

6 changes: 2 additions & 4 deletions pnpmfile.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
const path = require('node:path')
const { pathToFileURL } = require('node:url');
const { pathToFileURL } = require('node:url')

module.exports = {
hooks: {
updateConfig: (config) => {
// Resolve paths and convert to proper file URLs
const loaderPath = path.resolve(__dirname, 'esm_loader.mjs')
const loaderUrl = pathToFileURL(loaderPath).href
const baseUrl = pathToFileURL(path.resolve('./')).href

// Build the registration code
const registrationCode = `import{register}from'node:module';register('${loaderUrl}','${baseUrl}');`
const registrationCode = `import{registerHooks}from'node:module';import{resolve}from'${loaderUrl}';registerHooks({resolve});`
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// Create NODE_OPTIONS with properly encoded data URL
const importFlag = `--import=data:text/javascript,${encodeURIComponent(registrationCode)}`
Expand All @@ -19,4 +18,3 @@ module.exports = {
},
},
}