Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5353 #5355

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Issue 5353 #5355

merged 2 commits into from
Jan 13, 2025

Conversation

ferrarirosso
Copy link

What's in this Pull Request?

  1. When configuring multiple permissions for display, only the last clicked permission button is currently taken into account. Sometimes, the user has to disable all other permission buttons to display the correct one. I will fix this issue so that the web part displays all selected permissions simultaneously.

  2. After upgrading to version 1.20, the property pane settings may not synchronize correctly when changing the permission settings.

Node Version

v18.20.4

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@hugoabernier
Copy link
Collaborator

Many thanks @ferrarirosso for your update! Always appreciated!.

And thank you for your patience over the end of year break!

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@hugoabernier hugoabernier merged commit 4f2eded into pnp:main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple permissions display & fixes property pane bugs
2 participants