Rustdoc fix infinite recursion on mutually recursive Deref impl #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
changed the title
trinity-1686a
changed the title
pnkfelix
force-pushed
the
rustdoc-revert-deref-recur
branch
from
86e3f76
to
b894f75
Compare
pnkfelix
pushed a commit
that referenced
this pull request
Sep 9, 2021
Otherwise, we can get into a situation where you have a subtype obligation `#1 <: #2` pending, #1 is constrained by `check_casts`, but #2` is unaffected. Co-authored-by: Niko Matsakis <[email protected]>
pnkfelix
pushed a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Jaisurya Nanduri <[email protected]>
pnkfelix
pushed a commit
that referenced
this pull request
Jun 10, 2024
Co-authored-by: Jaisurya Nanduri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for rust-lang#85095 requires part of what is already on this branch, plus some additional code (see issue comments), and is closely related to the goal of this branch, so I think it's best to include the changes together. Feel free to close if you don't think so, in that case I'll open a pr upstream once rust-lang#84867 get merged