binding/abi: fix declaration for HAVE_WEAK_ATTRIBUTE#7491
Merged
hzhou merged 2 commits intopmodels:mainfrom Jul 1, 2025
Merged
binding/abi: fix declaration for HAVE_WEAK_ATTRIBUTE#7491hzhou merged 2 commits intopmodels:mainfrom
hzhou merged 2 commits intopmodels:mainfrom
Conversation
hzhou
force-pushed
the
2506_abi_weak
branch
2 times, most recently
from
cac5827 to
aae2ec3
Compare
Only handle types need use ABI types (e.g. ABI_Comm) in declarations. For example, MPI_Comm_copy_attr_function should not be replaced as ABI_Comm_copy_attr_function. Clang uses weak attributes. Slightly refactor to avoid duplicating setting re_Handle regrex.
Contributor
Author
|
test:mpich/custom |
Contributor
Author
|
test:mpich/ch3/most |
raffenet
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Only handle types need use ABI types (e.g. ABI_Comm) in declarations. For example, MPI_Comm_copy_attr_function should not be replaced as ABI_Comm_copy_attr_function. Clang uses weak attributes.
Fixes #7486
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.