romio: implement mpi-4 large count functions #5278

hzhou · 2021-05-12T21:21:26Z

Pull Request Description

Add large count functions:

MPI_File_read_c
MPI_File_read_all_c
MPI_File_read_all_begin_c
MPI_File_read_at_c
MPI_File_read_at_all_c
MPI_File_read_at_all_begin_c
MPI_File_read_ordered_c
MPI_File_read_ordered_begin_c
MPI_File_read_shared_c
MPI_File_write_c
MPI_File_write_all_c
MPI_File_write_all_begin_c
MPI_File_write_at_c
MPI_File_write_at_all_c
MPI_File_write_at_all_begin_c
MPI_File_write_ordered_c
MPI_File_write_ordered_begin_c
MPI_File_write_shared_c
MPI_File_iread_c
MPI_File_iread_all_c
MPI_File_iread_at_c
MPI_File_iread_at_all_c
MPI_File_iread_shared_c
MPI_File_iwrite_c
MPI_File_iwrite_all_c
MPI_File_iwrite_at_c
MPI_File_iwrite_at_all_c
MPI_File_iwrite_shared_c
MPI_File_get_type_extent_c
MPI_Register_datarep_c

Most of the functions only has one scalar parameters that is int count in small function, and MPI_Count count in the large function. This PR simply adds an assertion to ensure the large count can fit in the int and rely on compiler to do the integer conversion.

TODO in a future PR -- make internal functions to use MPI_Aint for count.

Author Checklist

Provide Description
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits Follow Good Practice
Commits are self-contained and do not do two things at once.
Commit message is of the form: module: short description
Commit message explains what's in the commit.
Passes All Tests
Whitespace checker. Warnings test. Additional tests via comments.
Contribution Agreement
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.

hzhou · 2021-05-14T13:24:49Z

test:mpich/ch3/most
test:mpich/ch4/most

hzhou · 2021-05-14T15:36:59Z

The freebsd failure is obviously not related, but we need to investigate the cause at some time.

./cxx/io/writeallx 4   -- TIMEOUT

test:mpich/ch3/sock

roblatham00

Great! MPICH used to have a policy against assert and I am glad to see we are rethinking that stance.

hzhou · 2021-05-14T16:01:36Z

Great! MPICH used to have a policy against assert and I am glad to see we are rethinking that stance.

Not embracing it, but better than not checking it. We need to turn the assertion into proper error checking at some point.

roblatham00

Sure, this is fine. No one uses this code so it's hard to test aggressively, but it's also unlikely anyone will report any bugs (if there are any: it looks correct to me!)

roblatham00

"this code" meant the datatype representation code. I thought github would let me comment on individual changesets

roblatham00 · 2021-05-14T17:17:43Z

src/mpi/romio/mpi-io/get_extent.c

+    /* FIXME: handle other file data representations */
+
+    MPI_Aint extent_i;
+    error_code = PMPI_Type_extent(datatype, &extent_i);


should this be PMPI_Type_get_extent since MPI_Type_extent is deprecated?

Added the last commit replaced the deprecated MPI_Type_extent.

roblatham00 · 2021-05-14T17:20:02Z

src/mpi/romio/mpi-io/iread.c

+
+    return error_code;
+}
+
 /* prevent multiple definitions of this routine */
 #ifdef MPIO_BUILD_PROFILING
 int MPIOI_File_iread(MPI_File fh, MPI_Offset offset, int file_ptr_type, void *buf, int count,


You'll need to bump the 'count' here to a 64 bit type, too -- which I warn you will cascade down into a lot of ROMIO.

'here' and all the other 'MPIOI_File_...' internal implemenations.

roblatham00 · 2021-05-14T17:25:10Z

OK, I see in your merge request description that you plan to bump up the internal type in a subsequent pull request. Then great: no harm in landing this request -- large counts are no worse than existing code.

hzhou · 2021-05-18T13:21:56Z

test:mpich/ch4/most
test:mpich/ch3/most
✔️

MPI_Count is now needed as a paprameter type for romio functions.

Declare the MPI-4 large count IO functions.

Poly functions will have both the regular kind and large count kind. Refator into MPIOI internal routine to prevent duplications.

MPI_Register_datarep and MPI_Register_datarep_c differ in the types of conversion function. Since we don't actually support non-NULL conversion functions, the only difference is in the parameter types.

In future PR, we'll make internal count using MPI_Aint. For now, we simply assert the values to fit in a int, and let compiler convert MPI_Count into int.

Replace the usage of deprecated MPI_Type_extent.

hzhou · 2021-05-29T19:24:28Z

Fixes #4880

hzhou force-pushed the 2105_romio_large branch 3 times, most recently from 73630d9 to 2ccc291 Compare May 13, 2021 18:04

hzhou requested a review from roblatham00 May 13, 2021 18:06

hzhou force-pushed the 2105_romio_large branch from 2ccc291 to 8317c9d Compare May 14, 2021 13:24

roblatham00 approved these changes May 14, 2021

View reviewed changes

roblatham00 reviewed May 14, 2021

View reviewed changes

hzhou force-pushed the 2105_romio_large branch from 8317c9d to cca82ad Compare May 18, 2021 13:20

hzhou force-pushed the 2105_romio_large branch from cca82ad to 237be90 Compare May 28, 2021 23:54

hzhou added 8 commits May 28, 2021 19:47

romio: initialize MPI_Count in all_romio_symbols

bf00050

MPI_Count is now needed as a paprameter type for romio functions.

romio: add large count prototypes

3065397

Declare the MPI-4 large count IO functions.

romio: refactor poly functions to use MPIOI routines

6072a3e

Poly functions will have both the regular kind and large count kind. Refator into MPIOI internal routine to prevent duplications.

romio: add implementations of large count functions

8049e86

romio: add MPI_File_get_type_extent_c

c58c808

romio: add MPI_Register_datarep_c

31e84c1

MPI_Register_datarep and MPI_Register_datarep_c differ in the types of conversion function. Since we don't actually support non-NULL conversion functions, the only difference is in the parameter types.

romio: add assertions in large count functions

fd4c444

In future PR, we'll make internal count using MPI_Aint. For now, we simply assert the values to fit in a int, and let compiler convert MPI_Count into int.

romio: use PMPI_Type_get_extent

f42f492

Replace the usage of deprecated MPI_Type_extent.

hzhou force-pushed the 2105_romio_large branch from 237be90 to f42f492 Compare May 29, 2021 00:48

hzhou merged commit d72be3c into pmodels:main May 29, 2021

hzhou deleted the 2105_romio_large branch May 29, 2021 00:53

hzhou mentioned this pull request May 29, 2021

romio: fix weak symbol blocks for large count functions #5310

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

romio: implement mpi-4 large count functions #5278

romio: implement mpi-4 large count functions #5278

hzhou commented May 12, 2021 •

edited

Loading

hzhou commented May 14, 2021

hzhou commented May 14, 2021

roblatham00 left a comment

hzhou commented May 14, 2021

roblatham00 left a comment

roblatham00 left a comment

roblatham00 May 14, 2021

hzhou May 18, 2021

roblatham00 May 14, 2021

roblatham00 May 14, 2021

roblatham00 commented May 14, 2021

hzhou commented May 18, 2021 •

edited

Loading

hzhou commented May 29, 2021

romio: implement mpi-4 large count functions #5278

romio: implement mpi-4 large count functions #5278

Conversation

hzhou commented May 12, 2021 • edited Loading

Pull Request Description

Author Checklist

hzhou commented May 14, 2021

hzhou commented May 14, 2021

roblatham00 left a comment

Choose a reason for hiding this comment

hzhou commented May 14, 2021

roblatham00 left a comment

Choose a reason for hiding this comment

roblatham00 left a comment

Choose a reason for hiding this comment

roblatham00 May 14, 2021

Choose a reason for hiding this comment

hzhou May 18, 2021

Choose a reason for hiding this comment

roblatham00 May 14, 2021

Choose a reason for hiding this comment

roblatham00 May 14, 2021

Choose a reason for hiding this comment

roblatham00 commented May 14, 2021

hzhou commented May 18, 2021 • edited Loading

hzhou commented May 29, 2021

hzhou commented May 12, 2021 •

edited

Loading

hzhou commented May 18, 2021 •

edited

Loading