coll: use assertion and int coercion local reduction op

The op functions are not using large count yet. TODO: fix this.
pmodels · Feb 10, 2021 · 8fc06c9 · 8fc06c9
1 parent ef2fca3
commit 8fc06c9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/mpi/coll/reduce_local/reduce_local.c b/src/mpi/coll/reduce_local/reduce_local.c
@@ -54,9 +54,12 @@ int MPIR_Reduce_local(const void *inbuf, void *inoutbuf, MPI_Aint count, MPI_Dat
     }
 
     /* actually perform the reduction */
+    /* FIXME: properly support large count reduction */
+    MPIR_Assert(count <= INT_MAX);
+    int icount = (int) count;
 #ifdef HAVE_CXX_BINDING
     if (is_cxx_uop) {
-        (*MPIR_Process.cxx_call_op_fn) (inbuf, inoutbuf, count, datatype, uop);
+        (*MPIR_Process.cxx_call_op_fn) (inbuf, inoutbuf, icount, datatype, uop);
     } else
 #endif
     {
@@ -68,10 +71,10 @@ int MPIR_Reduce_local(const void *inbuf, void *inoutbuf, MPI_Aint count, MPI_Dat
 
             (*uop_f77) ((void *) inbuf, inoutbuf, &lcount, &ldtype);
         } else {
-            (*uop) ((void *) inbuf, inoutbuf, &count, &datatype);
+            (*uop) ((void *) inbuf, inoutbuf, &icount, &datatype);
         }
 #else
-        (*uop) ((void *) inbuf, inoutbuf, &count, &datatype);
+        (*uop) ((void *) inbuf, inoutbuf, &icount, &datatype);
 #endif
     }