Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should use Object.is to compare two value #1314

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

hchlq
Copy link
Contributor

@hchlq hchlq commented Sep 26, 2022

Related Issues

Fixes #.

Summary

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a42b10a:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. We used to assume state is an object, but since v4.1, we support any values.

@dai-shi dai-shi added this to the v4.1.2 milestone Oct 9, 2022
@dai-shi dai-shi merged commit ae4cc7f into pmndrs:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants