Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Issue 1254 guides #1267

Merged
merged 3 commits into from
Sep 8, 2022
Merged

docs: Issue 1254 guides #1267

merged 3 commits into from
Sep 8, 2022

Conversation

joel-jo-querypie
Copy link
Contributor

Related Issues

Fixes #1254

Summary

Reviewed the following documentation:

  • Location of added content
  • typescript
  • custom storage is connected Hash url usage

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 6, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8273c5a:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@joel-jo-querypie joel-jo-querypie changed the title Update persisting-store-data.md docs: Issue 1254 docs state is connected URL hash guides Sep 6, 2022
@joel-jo-querypie joel-jo-querypie changed the title docs: Issue 1254 docs state is connected URL hash guides fix(docs): Issue 1254 guides Sep 6, 2022
dai-shi
dai-shi requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. Can you create a new md file in docs/guides/?
I haven't looked it closely, but one comment is: Can you add a codesandbox link for a working example?

@joel-jo-querypie
Copy link
Contributor Author

okay! thank u for comment.

@joel-jo-querypie
Add connect-to-state-with-url-hash.md
8273c5a 
  * Remove docs from persisting-store-data.md
@joel-jo-querypie
Copy link
Contributor Author

Reviewed the following documentation:

  • nav number of docs/guides/connect-to-state-with-url-hash.md
  • code sandbox demo

dai-shi
dai-shi approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution!

@dai-shi dai-shi merged commit faaed15 into pmndrs:main Sep 8, 2022
@joel-jo-querypie joel-jo-querypie changed the title fix(docs): Issue 1254 guides docs: Issue 1254 guides Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document for state with URL hash.
2 participants
@joel-jo-querypie @dai-shi