Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs page: flux inspired practice #1074

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

Carnageous
Copy link
Contributor

Wiki port of https://github.com/pmndrs/zustand/wiki/Flux-inspired-practice

I added just a little content and a snippet out of the readme to show examples on how flux-like patterns can be applied to zustand

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19b8e37:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution.

@dai-shi
Copy link
Member

dai-shi commented Jul 11, 2022

Please run yarn run prettier.

@Carnageous
Copy link
Contributor Author

Please run yarn run prettier.

Will do, but as I mentioned in the other PR, there are some issues with the prettier commands:

  • It does not run on windows
  • it adds weird semicolons in code in markdown files

I will try to resolve these and open a PR

@dai-shi
Copy link
Member

dai-shi commented Jul 11, 2022

It does not run on windows

oops.. hope you find a solution. we use the same command in zustand/jotai/valtio. is it also an issue with eslint? (you said so in #1057)

@dai-shi dai-shi merged commit 7470e9c into pmndrs:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants