Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(shallow): Compare functions test was added #1071

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

tbor00
Copy link
Contributor

@tbor00 tbor00 commented Jul 9, 2022

In this test compare function with shallow

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 057f85c:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@tbor00 tbor00 changed the title [Feature]: Compare functions test was added feature(shallow test): Compare functions test was added Jul 11, 2022
@dai-shi dai-shi changed the title feature(shallow test): Compare functions test was added chore(shallow): Compare functions test was added Jul 11, 2022
@dai-shi dai-shi changed the title chore(shallow): Compare functions test was added tests(shallow): Compare functions test was added Jul 11, 2022
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure if this is a typical usage #1064 (comment), but it should work.

So, I will need to update #1070 too.

@dai-shi
Copy link
Member

dai-shi commented Jul 11, 2022

Please run yarn run prettier.

@tbor00
Copy link
Contributor Author

tbor00 commented Jul 11, 2022

Hm, I'm not sure if this is a typical usage #1064 (comment), but it should work.

So, I will need to update #1070 too.

Yes, I think it is not a typical use. but it should work. In this case you need to update #1070

@dai-shi dai-shi merged commit f949d04 into pmndrs:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants