Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps)(example): incorrect peer dependency version of three #1056

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

rnike
Copy link
Contributor

@rnike rnike commented Jul 5, 2022

Saw a lot of warnings in the console on the demo site (https://zustand-demo.pmnd.rs/),

lots of warning

the reason is because the incorrect dependency of three,

incorrect deps

downgrade three to version 0.120.1 the warnings no longer exist.

Related issue: pmndrs/postprocessing#246

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c1dd78:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@rnike rnike changed the title build(deps): Downgrade three version to "0.120.1" fix(deps): incorrect peer dependency version of three Jul 5, 2022
@rnike rnike changed the title fix(deps): incorrect peer dependency version of three fix(deps)(example): incorrect peer dependency version of three Jul 5, 2022
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid someone will update it in the future without noticing, but it looks fine for now.

@dai-shi dai-shi merged commit b06a8a0 into pmndrs:main Jul 5, 2022
@rnike
Copy link
Contributor Author

rnike commented Jul 6, 2022

Another solution is to upgrade react-postprocessing, I've tried but it needs to upgrade a lot of related dependencies(including react & react-dom), and the tree shaking of the three package written in config-overrides.js also needs a refactor or rewrite, the diff will be massive if I am going to do that, I chose the simplest solution in this PR.

@dai-shi I have a question here, what do you or the team think of upgrading dependencies for the example? Want to know in your opinion if doing this is valuable or not.

@dai-shi
Copy link
Member

dai-shi commented Jul 6, 2022

examples folder is not actively maintained by me or the team. It's improved by a few contributors including you.
I'm fine with dropping react-app-rewired and customize-cra, which complicate things.
#968 is also related.

@rnike rnike deleted the fix-warning-in-postprocessing branch July 6, 2022 03:34
@rnike
Copy link
Contributor Author

rnike commented Jul 6, 2022

got it, might take a look when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants