Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Canvas.tsx types and how children is rendered #3264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joevingracien
Copy link

This change is an attempt to make children "optional" and get rid of types workarounds.

For instance in cases like react-three-next:

export default function Scene({ ...props }) {
  return (
    <Canvas {...props}
      onCreated={(state) => (state.gl.toneMapping = THREE.AgXToneMapping)}
    >
      {/* @ts-ignore */}
      <r3f.Out />
      <Preload all />
    </Canvas>
  )
}

We wouldn't be obliged to put @ts-ignore anymore.

This change is an attempt to make children "optional" and get rid of types workarounds. 

For instance in cases like react-three-next:

export default function Scene({ ...props }) {
  return (
    <Canvas {...props}
      onCreated={(state) => (state.gl.toneMapping = THREE.AgXToneMapping)}
    >
      {/* @ts-ignore */}
      <r3f.Out />
      <Preload all />
    </Canvas>
  )
}

We wouldn't be obliged to put @ts-ignore anymore.
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5e3641:

Sandbox Source
example Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant