-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property "trim" of undefined #3333
Comments
There seems to be something wrong with version 8.17.*, "@react-three/fiber": "8.16.8", Try it, |
If 8.16.8 works, does 8.17.5 with |
Yes, adding events=null does not solve the trim error. |
Yes I am aware, raised this issue specifically for version 18.17.5. It started recurring after #3252 got merged I think. |
Faced with same issue. I patched library. |
still a issue |
developing a small project i ran through the same error, fixed by going on the file node_modules/three/build/three.cjs and on the function "onFirstUse", inside the first if, theres this line of code: const programLog = gl.getProgramInfoLog( program ).trim(); on the "if ( renderer.debug.checkShaderErrors )" i added the "program" property. Now it is "if ( renderer.debug.checkShaderErrors && program )". solved for me |
i am having this problem, any solution ? |
That sounds severely broken and undefined behavior. Does 8.16.8 work for you by chance? I can't recreate this, and I anticipate it being device specific (Android). |
Is not device specific, i am having this issue in IOS |
Which device or iOS version? This is either device (GPU) specific or a grossly broken build/implementation of WebGL (via expo-gl). It is not valid for programs to continue if a resource returns |
I followed the tutorial for React Native without Expo and installed all the required dependencies. I tested the app on both an iOS 18.2 emulator and a real device (iPhone 6s running iOS 15.8.2). Here are the versions of the libraries I'm using: expo: ^52.0.0 Let me know if there are any specific tests or configurations I should try to address this issue. |
Try specifying I don't have an iPhone 6 on hand, so I can't quickly verify. I am wary of iOS 15, which was riddled with OS bugs from 15.3-15.4. I'll take a closer look as to how this is reachable. |
Specifying "@react-three/fiber": "8.16.8" worked successfully. However, whenever I try to use anything from @react-three/drei/native, I get the same error. Which version of @react-three/drei should I use to make it work? |
@CodyJasonBennett I am able to reproduce this error. I've included the following expo snack: https://snack.expo.dev/@glthomas/react-three-fiber-example?platform=ios
|
I am having the same issue but only in my iPad (both Air M1 (iPadOS 18.2.1) and emulator) . Android seems to work fine
|
This error is coming from a code path that should be unreachable and is not valid for an OpenGL implementation to do #3333 (comment). My worry here is that we're running into unsupported OpenGL drivers (which Apple is notorious for and is what |
The only way I can avoid the error is by using the events={null} in my . However, I am losing the orbit controls..
|
Using a suspense inside the canvas seems to solve the issue for me on release builds, this breaks completely breaks dev builds whereas before the error could be dismissed. This is on a physical android device. |
still a issue |
One workaround: <Canvas
gl={{ debug: { checkShaderErrors: false, onShaderError: null } }}
> The error gets thrown here:
Disabling |
I wouldn't be opposed to including that as a workaround here, but this is quite a scary issue since any WebGL resource returning |
Still an issue, just after I installed the lib and created a first Canvas. |
This is the error that appears on fresh installation of React three Fiber v18.17.5
It shows up atleast twice and sometimes thrice.
Device : Samsung Galaxy Tab A9
Android Version : Android 14
Repo Link to reproduce: Link
The text was updated successfully, but these errors were encountered: